For what it's worth - we noticed this missing EOL as our tests concatenate configuration directives to the configuration file. This resulted in an invalid configuration line.
(That said, the OSG tests need to be updated regardless because configuration isn't parsed after the continue statement...)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/xrootd/xrootd","title":"xrootd/xrootd","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/xrootd/xrootd"}},"updates":{"snippets":[{"icon":"PERSON","message":"@bbockelm in #901: For what it's worth - we noticed this missing EOL as our tests concatenate configuration directives to the configuration file. This resulted in an invalid configuration line.\r\n\r\n(That said, the OSG tests need to be updated regardless because configuration isn't parsed after the continue statement...)"}],"action":{"name":"View Pull Request","url":"https://github.com/xrootd/xrootd/pull/901#issuecomment-459528183"}}}
[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/xrootd/xrootd/pull/901#issuecomment-459528183",
"url": "https://github.com/xrootd/xrootd/pull/901#issuecomment-459528183",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]
Use REPLY-ALL to reply to list
To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1