When testing 4.9.1-rc1, @jthiltges reported that macaroons.onmissing had undefined behavior if it was not set in the configuration file (unfortunately, the undefined behavior for my test platforms was the same as the expected behavior ... but not in production!).
Since I was hitting the codebase with valgrind, this PR also fixes two minor memory leaks and one uninitialized read.
@simonmichal - please backport for 4.9.1 final!
You can view, comment on, or merge this pull request online at:
https://github.com/xrootd/xrootd/pull/945
Commit Summary
- Set the `macaroons.onmissing` default.
- Interact with json-c appropriately for request.
- Ensure we delete macaroon object after use.
File Changes
Patch Links:
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/xrootd/xrootd","title":"xrootd/xrootd","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/xrootd/xrootd"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"[XrdMacaroons] Fix default for `macaroons.onmissing` (#945)"}],"action":{"name":"View Pull Request","url":"https://github.com/xrootd/xrootd/pull/945"}}}
[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/xrootd/xrootd/pull/945",
"url": "https://github.com/xrootd/xrootd/pull/945",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]
Use REPLY-ALL to reply to list
To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1