@osschar : I was able to reproduce the problem you've spotted with valgrind and here's the respective fix: d0eca52
It's great that you've been able to trigger it, it was definitely a dangerous corner case! The long story short, due to this memory realloc:
https://github.com/xrootd/xrootd/blob/d0eca522e849a5f56d5e5a77f423e5d7b1b5dd1e/src/XrdCl/XrdClXRootDTransport.cc#L712
a pointer to ClientRequestHdr that is being used to release SID became invalid (this could only happen in case of connection problem, and only for read requests).
I ported both commits to the stable-4.9.x branch, maybe you could test and then we can close this issue?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/xrootd/xrootd","title":"xrootd/xrootd","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/xrootd/xrootd"}},"updates":{"snippets":[{"icon":"PERSON","message":"@simonmichal in #943: @osschar : I was able to reproduce the problem you've spotted with valgrind and here's the respective fix: d0eca52\r\nIt's great that you've been able to trigger it, it was definitely a dangerous corner case! The long story short, due to this memory realloc:\r\nhttps://github.com/xrootd/xrootd/blob/d0eca522e849a5f56d5e5a77f423e5d7b1b5dd1e/src/XrdCl/XrdClXRootDTransport.cc#L712\r\na pointer to ClientRequestHdr that is being used to release SID became invalid (this could only happen in case of connection problem, and only for read requests).\r\n\r\nI ported both commits to the _stable-4.9.x_ branch, maybe you could test and then we can close this issue?"}],"action":{"name":"View Issue","url":"https://github.com/xrootd/xrootd/issues/943#issuecomment-476676591"}}}
[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/xrootd/xrootd/issues/943#issuecomment-476676591",
"url": "https://github.com/xrootd/xrootd/issues/943#issuecomment-476676591",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]
Use REPLY-ALL to reply to list
To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1
