I did check before using the %z in the PR that the %z was used in the code already. It is. In not just a handful places. I would have used the cast to long version if it wasn't. But if you insist on using the cast to long approach I can change it. Let me know.
Why did you close the PR if you were planing to accept it after changes?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/xrootd/xrootd","title":"xrootd/xrootd","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/xrootd/xrootd"}},"updates":{"snippets":[{"icon":"PERSON","message":"@ellert in #911: I did check before using the %z in the PR that the %z was used in the code already. It is. In not just a handful places. I would have used the cast to long version if it wasn't. But if you insist on using the cast to long approach I can change it. Let me know.\r\nWhy did you close the PR if you were planing to accept it after changes?\r\n"}],"action":{"name":"View Pull Request","url":"https://github.com/xrootd/xrootd/pull/911#issuecomment-469597159"}}}
[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/xrootd/xrootd/pull/911#issuecomment-469597159",
"url": "https://github.com/xrootd/xrootd/pull/911#issuecomment-469597159",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]
Use REPLY-ALL to reply to list
To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1
