Thanks for taking a look. You're right, and in fact I've hit those issues in our own version of this, but had forgotten to fix them. I'll try to solve this as soon as possible, and try adding some unit tests for the code in the process.
Coming back to this with fresher eyes, I'm wondering if I've located the glob.py module in the right place. Should it really be below src/ ? Looking at the setup.py file I guess this should really be imported via the pyxrootd package rather than the XrootD one?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/xrootd/xrootd","title":"xrootd/xrootd","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/xrootd/xrootd"}},"updates":{"snippets":[{"icon":"PERSON","message":"@benkrikler in #854: Thanks for taking a look. You're right, and in fact I've hit those issues in our own version of this, but had forgotten to fix them. I'll try to solve this as soon as possible, and try adding some unit tests for the code in the process.\r\n\r\nComing back to this with fresher eyes, I'm wondering if I've located the `glob.py` module in the right place. Should it really be below `src/` ? Looking at the setup.py file I guess this should really be imported via the `pyxrootd` package rather than the `XrootD` one?"}],"action":{"name":"View Pull Request","url":"https://github.com/xrootd/xrootd/pull/854#issuecomment-482135729"}}}
[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/xrootd/xrootd/pull/854#issuecomment-482135729",
"url": "https://github.com/xrootd/xrootd/pull/854#issuecomment-482135729",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]
Use REPLY-ALL to reply to list
To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1
