Print

Print


Hi,

I took a look at the problems we were having converting the EVIO data from the calibration runs, and I think that I cleared up the two main problems that were reported.

This should fix the crash when the "ti_time_offsets" condition is missing for the run.

https://github.com/JeffersonLab/hps-java/pull/470

And this should resolve the issues with converting the trigger data banks.

https://github.com/JeffersonLab/hps-java/pull/469

There was an extra word added to the head bank with the trigger data (thanks for this info, Omar), but this should not affect the existing code, as far as I can tell.  As long as there is enough data in the int bank, it should be decoded fine in the current code with the extra word present.

I tested these changes using Andrea's command line for running the ECal LED calibrations.

https://github.com/JeffersonLab/hps-java/issues/466#issuecomment-491152881

I was able to confirm that the crash at the beginning of the job from the missing conditions was resolved, and the error message having to do with trigger data no longer shows up.

A timely review and merge of these changes would be helpful to remove these errors from conversion of the EVIO to LCIO for our current data.

If you feel that you can review these changes, then please let me know and I'll add you as an additional reviewer (or just add yourself if you are able).

Thanks!

--Jeremy

########################################################################
Use REPLY-ALL to reply to list

To unsubscribe from the HPS-SOFTWARE list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=HPS-SOFTWARE&A=1