Hi Brian,
I am generally OK with that though we should look to see if we can use the
SFS interface that teh xrootd protocol loads as opposed to loading it
twice. The bigger question is why are you using the SFS interface and not
the oss interface?
Andy
On Wed, 7 Aug 2019, Brian P Bockelman wrote:
> When the TPC library was maintained out-of-tree, we had to stick to the public interfaces. This forced the filesystem loader code to duplicate a lot of logic (not necessarily 100% correct).
>
> With this change, the plugin will make a call directly into the internal function that does the SFS loading elsewhere in Xrootd.
>
> @abh3 - if you are OK with the approach and implementation, there's another place where we can remove code in `XrdMacaroons`.
>
> Fixes #1034
> You can view, comment on, or merge this pull request online at:
>
> https://github.com/xrootd/xrootd/pull/1035
>
> -- Commit Summary --
>
> * Fix const'ness of the loader declaration.
> * Switch from homegrown plugin loader to the common one.
>
> -- File Changes --
>
> M src/XrdTpc/XrdTpcConfigure.cc (73)
> M src/XrdXrootd/XrdXrootdConfig.cc (2)
> M src/XrdXrootd/XrdXrootdLoadLib.cc (2)
>
> -- Patch Links --
>
> https://github.com/xrootd/xrootd/pull/1035.patch
> https://github.com/xrootd/xrootd/pull/1035.diff
>
> --
> You are receiving this because you were mentioned.
> Reply to this email directly or view it on GitHub:
> https://github.com/xrootd/xrootd/pull/1035
>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/xrootd/xrootd/pull/1035?email_source=notifications\u0026email_token=AA7NRDVLCME7DFPQJLHIC4LQDMUFNA5CNFSM4IKA6D6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3ZSLRA#issuecomment-519251396",
"url": "https://github.com/xrootd/xrootd/pull/1035?email_source=notifications\u0026email_token=AA7NRDVLCME7DFPQJLHIC4LQDMUFNA5CNFSM4IKA6D6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3ZSLRA#issuecomment-519251396",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]
Use REPLY-ALL to reply to list
To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1
