Print

Print

If the XrdCl::File::Read() call fails, bytesRead is not initialized. This leads to a segfault when the buffer is passed to Python PyBytes_FromStringAndSize()

Valgrind output for xrootd-4.10.0-1.osg34.el7.x86_64:

2019-10-03 19:00:56 ==31606== Conditional jump or move depends on uninitialised value(s)
2019-10-03 19:00:56 ==31606==    at 0x4EC9D64: PyString_FromStringAndSize (in /usr/lib64/libpython2.7.so.1.0)
2019-10-03 19:00:56 ==31606==    by 0x117C57B8: PyXRootD::File::Read(PyXRootD::File*, _object*, _object*) (PyXRootDFile.cc:198)
2019-10-03 19:00:56 ==31606==    by 0x4F1BD3F: PyEval_EvalFrameEx (in /usr/lib64/libpython2.7.so.1.0)

You can view, comment on, or merge this pull request online at:

  https://github.com/xrootd/xrootd/pull/1063

Commit Summary

File Changes

Patch Links:

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/xrootd/xrootd/pull/1063?email_source=notifications\u0026email_token=AA7NRDWW7KFIX4J4SHVFURDQM6WF3A5CNFSM4I5UOJ22YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HPYZ7PA", "url": "https://github.com/xrootd/xrootd/pull/1063?email_source=notifications\u0026email_token=AA7NRDWW7KFIX4J4SHVFURDQM6WF3A5CNFSM4I5UOJ22YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HPYZ7PA", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1