 |
 |
First, what is the motivation (presumably some requirement) for this additional code? This kind of stuff really belongs the monitoring stream not in the log. That said, a) it's Linux specific so it needs to be if-def'd, b) please use sizeof() when referencing previously sized arrays, c) snprintf error return will always be negative (it really can't return 0 unless nothing was in the format string which isn't the case); the '< 1' should be '< 0' for clarity, and d) please use XrdSysE2T() when printing errors; printing just the errno is not particularly meaningful. Finally, the code is rather long and obscures what is being done in a rather complicated part of the code. It should be moved to a separate method. So, let's first discuss the need fand proper placement or this before we move forward. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/xrootd/xrootd/pull/1142#issuecomment-591679850 ######################################################################## Use REPLY-ALL to reply to list To unsubscribe from the XROOTD-DEV list, click the following link: https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1