Per the WebDAV spec, the correct MKCOL response for when a collection already exists is 405.

Without this fix, gfal-mkdir interprets the EEXISTS response to MKCOL as a file-not-found. This causes the client to attempt to make the parent directory.

This fixes a race condition in FTS that we've been triggering on occasion with this pattern:

- Client 1 does a stat on path `/foo/bar`; file-not-found is returned
- Client 2 does a stat on path `/foo/bar`; file-not-found is returned
- Client 1 does a mkdir on path `/foo/bar`; successful!
- Client 2 does a mkdir on path `/foo/bar`; file-not-found is returned (due to this bug).
- Client 2 does a mkdir on path `/foo`; permission denied is returned.
- Client 2 tells the user the permission is denied.

So client 2 returns a permission problem because it can't make a top-level directory when, in reality, the path it wants already exists!

@simonmichal - please consider this for backport. It's causing transfer failures in production and should be a relatively safe, simple backport.
@ffurano - please review

You can view, comment on, or merge this pull request online at:

  https://github.com/xrootd/xrootd/pull/1164

Commit Summary

File Changes

Patch Links:

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/xrootd/xrootd/pull/1164", "url": "https://github.com/xrootd/xrootd/pull/1164", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1