@simonmichal commented on this pull request.
> @@ -633,6 +635,19 @@ int XrdHttpProtocol::Process(XrdLink *lp) // We ignore the argument here
sbio = CreateBIO(Link);
BIO_set_nbio(sbio, 1);
ssl = SSL_new(sslctx);
+
+ // On newer versions of OpenSSL, we use the periodically
+ // updated store `verify_store` with the `x509_store_lock`
+ // held; older OpenSSL versions are missing `SSL_set1_*_cert_store`,
+ // so we simply rely on the global one in SSL_CTX. The latter
+ // doesn't refresh the verify store, which causes issues with some
+ // plugins.
+#if OPENSSL_VERSION_NUMBER >= 0x010100000L
I'm not sure if it is intentional, but it will also exclude any variant of RHEL7, as e.g. both Centos7 and CC7 have openssl `1.0.2k`. From what I see `SSL_set1_verify_cert_store` & `SSL_set1_chain_cert_store` are available in OpenSSL 1.0.2 (see e.g. https://github.com/openssl/openssl/blob/OpenSSL_1_0_2k/ssl/ssl.h). If we would like to include RHEL7 we should test for `OPENSSL_VERSION_NUMBER >= 0x10002000L`.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/xrootd/xrootd/pull/1186#discussion_r417192672
########################################################################
Use REPLY-ALL to reply to list
To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1
