I can't say this pull request makes me happy. We've been trying to consolidate all of the x509 stuff in as few places as possible and this pull requests further splatters x509 dependencies all over the http code. It's going to be a long-term maintenance nightmare. It's certainly makes consolidation monumentally more difficult. Sure, this was the quick way of doing this but leaves the maintainers holding the bag and that is not a good approach. For instance, why wasn't the parsing logic put in the VOMS extractor plugin as it's the one that has to deal with this? At least the dependencies would be in a single place. Also, I still don't fully understand what problem this is trying to solve as we've been using proxy certificates for the longest time with the code, at least via the VOMS plugin. So, it's not even clear what is being gained here. So, please some background and explanation would be warranted; especially for such a far reaching pull request.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/xrootd/xrootd/pull/1224#issuecomment-651557723", "url": "https://github.com/xrootd/xrootd/pull/1224#issuecomment-651557723", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1