Print

Print

@esindril commented on this pull request.

In src/XrdHttp/XrdHttpSecurity.cc:

> +
+void
+XrdHttpProtocol::HandleGridMap(XrdLink* lp)
+{
+  char bufname[256];
+  XrdCryptoX509Chain chain;
+  XrdTlsPeerCerts* pc = lp->getPeerCerts();
+
+  if (myCryptoFactory && pc &&
+      !myCryptoFactory->X509ParseStack()(pc, &chain)) {
+    TRACEI(DEBUG, "No certificate found in peer chain.");
+    delete pc;
+    return;
+  }
+
+  delete pc;

There is (was) a delete for both the successful and the failure case, I don't see the leak here. Anyway not it's on the stack.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/xrootd/xrootd/pull/1231#discussion_r448805181", "url": "https://github.com/xrootd/xrootd/pull/1231#discussion_r448805181", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1