 |
 |
@abh3 requested changes on this pull request. Looks good. So, the only strong suggestion I have to allow a site to choose the policy for the voms extractor and gridmap file mapping. As I said in a previous mail file, that short circuits any dispute whether or not failure in either plugin should fail the whole authentication. Likely the easiest and most understandable addition is: http.gridmap [require] <path> http.secxtrator [require] <path> So, simply, if "require" is specified then authentication should fail if the respective plugin returns failure. Now, I hate punching the button "request changes" because it makes it sound like something is wrong with your most recent changes. That is not so. However, the addition of the "require" policy would finally bring closure all the loose authentication ends in http. So, please understand. (BTW the reason it took me so long is that I finally got away from a computer this long holiday weekend - yay). -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/xrootd/xrootd/pull/1239#pullrequestreview-443546637 ######################################################################## Use REPLY-ALL to reply to list To unsubscribe from the XROOTD-DEV list, click the following link: https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1