Print

---

@pkramp commented on this pull request.



> @@ -661,6 +661,13 @@ bool XrdHttpReq::Redir(XrdXrootd::Bridge::Context &info, //!< the result context
   else
     redirdest = "Location: http://";
   
+  // port -1 signals redirect to local filesystem
+  // switch to file:// protocol
+  if (port == -1)

Hi Andy, thanks.

do you merely want a change such as this:
```
  // port < 0 signals switch to full URL
  if (port < 0)
  {
    TRACE(REQ, " XrdHttpReq::Redir Switching to file:// ");
    redirdest = "Location: file://";
  }
```

And I want to make sure I understand you correctly:
Wouldn't checking for port < 0 make everything more ambiguous?
Because new use cases that would utilize other ports < 0, would trigger the local file redirect as well?

Or do you mean that there will only be the one use case for ports < 0, and that will remain to be local file redirect?
And I am unclear on the term "regular full URL". In what other cases does xrootd handle non host?token:port targets than in the file://-protocol?

Cheers,
Paul

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/xrootd/xrootd/pull/1242#discussion_r451461254

########################################################################
Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1