That's OK, nothing wrong with eliminating dead code as it is ugly and can be confusing. It just means we need to review the pull request to extract the appropriate essence. I do appreciate that you provided a focus target which gives us an important starting point. So, I hope you don't mind that a review will ask for modifications of this pull request. I think this is worth pursuing to its conclusion.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/xrootd/xrootd/pull/1282#issuecomment-693502617", "url": "https://github.com/xrootd/xrootd/pull/1282#issuecomment-693502617", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1