While it technically doesn't break the ABI per se the problem is that the ManOss inherits the Manager API and the change reverts the the override of Calc to its default implementation. While that is counteracted by the change to the default manager implementation it doesn't help should someone replace the manager plugin or one of the Calc's the default manager implementation would use. In other words, the change is a semantic change that makes it difficult to know what the end result will be when site-specific plugins are specified to override various default implementations. There is a more consistent way of doing this that keeps the overt semantics the same but yet passes the env to the Oss open() as needed. That's what I mean to say. Let me work on a solution that doesn't change the override behavior.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/xrootd/xrootd/pull/1319#issuecomment-720772555", "url": "https://github.com/xrootd/xrootd/pull/1319#issuecomment-720772555", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1