Hi David,
Correct! Thank you. If you want to get credit for this could you create a
pull request with the change? Otherwise, I can change it but then your
obervation gets lost.
Andy
On Fri, 20 Nov 2020, David Smith wrote:
> In XrdOss/XrdOss.cc (current head 8db3054), XrdOssDF::pgWrite:
>
> ```
> 228: if (!XrdOucCRC::Ver32C((void *)buffer, wrlen, csvec, valcs))
> 229: return -EDOM;
> 230: }
> ```
>
> There are several overloaded versions of Ver32C, but I believe this one returns the index of the first mismatching checksum, so the check on line 228 is not general enough to catch all mismatches, probably it should be >= 0.
>
> --
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly or view it on GitHub:
> https://github.com/xrootd/xrootd/issues/1332
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/xrootd/xrootd/issues/1332#issuecomment-731033005",
"url": "https://github.com/xrootd/xrootd/issues/1332#issuecomment-731033005",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]
Use REPLY-ALL to reply to list
To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1