Thanks David. Actually, I've already reviewed it and you are correct
(assuming the patch will be the expected one). I am big on giving credit
where it's due. In github this is the only way of doing it publicly which
I am a big fan of. Anyone who corrects a bug should be the one that
gets credit for it! Yes, for more involved patches, this is the only way
of doing a review but it is still relevant to IP recognition.
Andy
On Fri, 20 Nov 2020, David Smith wrote:
> Hi Andy,
>
> OK. I'll open a PR (in a few minutes) - not because it's an issue of wanting credit, but I guess it's a better tracked process, a place to review before merge etc.
>
> David
>
> --
> You are receiving this because you commented.
> Reply to this email directly or view it on GitHub:
> https://github.com/xrootd/xrootd/issues/1332#issuecomment-731041477
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/xrootd/xrootd/issues/1332#issuecomment-731048945",
"url": "https://github.com/xrootd/xrootd/issues/1332#issuecomment-731048945",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]
Use REPLY-ALL to reply to list
To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1