Last argument of pgWrite() is opts rather than a size. So in this patch I set the opts to 0. I don't think there's any advantage to specify Verify here, since the data are already available to a cache client by reading from RAM so it would be late to discover a mismatch.
The data almost certainly do match their checksums (if present) since they came from pgRead, so either XrdCl verified received checksums or they were generated based on data received over TLS. (I think XrdCl does always verify received checksums, but protocol spec says it only has to verify if the connection is not TLS, and then conceivably they could mismatch if origin sent them mismatching).
You can view, comment on, or merge this pull request online at:
https://github.com/xrootd/xrootd/pull/1334
-- Commit Summary --
* [XCache] Fix options argument to pgwrite.
-- File Changes --
M src/XrdPfc/XrdPfcFile.cc (2)
-- Patch Links --
https://github.com/xrootd/xrootd/pull/1334.patch
https://github.com/xrootd/xrootd/pull/1334.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/xrootd/xrootd/pull/1334
########################################################################
Use REPLY-ALL to reply to list
To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1
