Print

Print

Will XrdSysMutex::TimedLock( int wait_ms ) ever be called with wait_ms > 3294 ms?
3295 · 1000000 + 999999999 = 4294999999 > 4294967295 = 2³² - 1
The overflow can be avoided if
wait.tv_nsec += wait_ms * 1000000;
is replaced by
wait.tv_sec += wait_ms / 1000;
wait.tv_nsec += (wait_ms % 1000) * 1000000;

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/xrootd/xrootd/pull/1351#issuecomment-739657579", "url": "https://github.com/xrootd/xrootd/pull/1351#issuecomment-739657579", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1