@abh3 commented on this pull request. > @@ -80,7 +80,7 @@ private: if (!size_desired) {return 0;} } int retval = stream.Write(m_offset, &m_buffer[0], size_desired, force); - if (retval < 0 && (static_cast<size_t>(retval) != size_desired)) { + if ((retval == -1) || (static_cast<size_t>(retval) != size_desired)) { Yes, this will work but a more understandable condition would be if ((retval < 0) || .... Since it's still possible to recast a negative value to unsigned which makes no sense. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/xrootd/xrootd/pull/1387#pullrequestreview-574903952 ######################################################################## Use REPLY-ALL to reply to list To unsubscribe from the XROOTD-DEV list, click the following link: https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1