 |
 |
@bbockelm One more thing which is very worrisome. Code surrounding XrdTpcStream.cc:112 iteratively handles the buffers but the call in that line re-enters the same method (i.e. it is a recursive call) and invariable repeats the same code loop. I don't necessarily see any protection of the iterator and indeed, if one of the buffer is deleted the resumption of the block upon return may cause undefined results. Why was this done recursively in the first place? Even if it works the same code block is repeated O(N**2) and is totally unnecessary. At best the accounting will be completely wrong as far as I can tell. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/xrootd/xrootd/issues/1384#issuecomment-766307780 ######################################################################## Use REPLY-ALL to reply to list To unsubscribe from the XROOTD-DEV list, click the following link: https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1