@bbockelm commented on this pull request.
> @@ -80,7 +80,7 @@ private:
if (!size_desired) {return 0;}
}
int retval = stream.Write(m_offset, &m_buffer[0], size_desired, force);
- if (retval < 0 && (static_cast<size_t>(retval) != size_desired)) {
+ if ((retval == -1) || (static_cast<size_t>(retval) != size_desired)) {
Yup - I can make that tweak. Actually the only valid error code is `SFS_ERROR` (I don't use the define to avoid an import) but checking for any negative value seems reasonably future-proof.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/xrootd/xrootd/pull/1387#discussion_r563441275
########################################################################
Use REPLY-ALL to reply to list
To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1
