Print

Print


  Branch: refs/heads/master
  Home:   https://github.com/xrootd/xrootd
  Commit: 8e84fe4106b777b3351878d8c4af74a431cac2d6
      https://github.com/xrootd/xrootd/commit/8e84fe4106b777b3351878d8c4af74a431cac2d6
  Author: Brian Bockelman <[log in to unmask]>
  Date:   2021-01-30 (Sat, 30 Jan 2021)

  Changed paths:
    M src/XrdTpc/XrdTpcStream.cc
    M src/XrdTpc/XrdTpcStream.hh

  Log Message:
  -----------
  XrdTpc: Factor out recursive writes.

This separates the writing methods of the stream to avoid potential
recursion when dumping buffered data.  This also allows the buffer
to accept partial data so the beginning offset of the buffer is
always a multiple of the buffer size (i.e., the buffer offsets
always stay MB-aligned).

With this, a single incoming buffer from curl may be split across
two entries in order to keep alignment.


  Commit: f8970471e06da3e1dee53b1f62df54ca001deed5
      https://github.com/xrootd/xrootd/commit/f8970471e06da3e1dee53b1f62df54ca001deed5
  Author: Brian Bockelman <[log in to unmask]>
  Date:   2021-01-30 (Sat, 30 Jan 2021)

  Changed paths:
    M src/XrdTpc/XrdTpcStream.hh

  Log Message:
  -----------
  XrdTpc: Do not allow partial buffer writes

The multistream code uses an occupied buffer as an indication that
a request is ongoing; for now, we can't do partial buffer writes
as this causes the back-off code to think the buffer is free and
start too many requests.


  Commit: 3d28dd50dc1e467d3fbb83d77a2144b22fa4c74a
      https://github.com/xrootd/xrootd/commit/3d28dd50dc1e467d3fbb83d77a2144b22fa4c74a
  Author: Brian Bockelman <[log in to unmask]>
  Date:   2021-01-30 (Sat, 30 Jan 2021)

  Changed paths:
    M src/XrdTpc/XrdTpcTPC.cc
    M src/XrdTpc/XrdTpcTPC.hh

  Log Message:
  -----------
  XrdTpc: Adjust buffer size based on number of streams.

As we only write when buffers are full and we don't need a full 16MB
buffer when we are doing single-streams (for single stream, we're only
waiting to accumulate a "large-enough" MB-aligned buffer), we can
simply decrease the buffer size.  Saves some allocated-but-unused
space.


  Commit: 3b40aa1163db5044be7b38f5a76dac03610e557f
      https://github.com/xrootd/xrootd/commit/3b40aa1163db5044be7b38f5a76dac03610e557f
  Author: Brian Bockelman <[log in to unmask]>
  Date:   2021-01-30 (Sat, 30 Jan 2021)

  Changed paths:
    M src/XrdTpc/XrdTpcStream.cc

  Log Message:
  -----------
  XrdTpc: Always populate error buffer with messages.

Even when there's an internal logic error, make sure the Write
method populates the error message - if nothing else, will be useful
for debugging.


  Commit: defdc085cddcd11f30d3b89d7af8a54394c272d0
      https://github.com/xrootd/xrootd/commit/defdc085cddcd11f30d3b89d7af8a54394c272d0
  Author: Andrew Hanushevsky <[log in to unmask]>
  Date:   2021-01-31 (Sun, 31 Jan 2021)

  Changed paths:
    M src/XrdTpc/XrdTpcStream.cc
    M src/XrdTpc/XrdTpcStream.hh
    M src/XrdTpc/XrdTpcTPC.cc
    M src/XrdTpc/XrdTpcTPC.hh

  Log Message:
  -----------
  Merge pull request #1391 from bbockelm/xrdtpc_stream_write_refactor

XrdTPC: Refactor stream writes


Compare: https://github.com/xrootd/xrootd/compare/a31d667f02a6...defdc085cddc

########################################################################
Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1