This fixes an incorrect copy (which should have been a reference, resulting in a leak) and a use-after-free found by valgrind. Those are in the multistream code and, I believe, currently rarely used.
It also fixes a potential pointer deref - if libcurl failed to malloc a new handle, then we used the handle before checking for a null pointer. I also consider this fairly unlikely to occur in reality but a worthwhile fix.
You can view, comment on, or merge this pull request online at:
https://github.com/xrootd/xrootd/pull/1423
-- Commit Summary --
* XrdTpc: Fixup some minor memory bugs
-- File Changes --
M src/XrdTpc/XrdTpcMultistream.cc (4)
M src/XrdTpc/XrdTpcTPC.cc (6)
M src/XrdTpc/XrdTpcTPC.hh (2)
-- Patch Links --
https://github.com/xrootd/xrootd/pull/1423.patch
https://github.com/xrootd/xrootd/pull/1423.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/xrootd/xrootd/pull/1423
########################################################################
Use REPLY-ALL to reply to list
To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1
