Print

Print

@bbockelm commented on this pull request.

In src/XrdTpc/XrdTpcNSSSupport.cc:

> +        close(m_fd);
+    }
+}
+
+
+XrdTpcNSSSupport::TempCAGuard::TempCAGuard(int fd, const std::string &fname)
+    : m_fd(fd), m_fname(fname)
+    {}
+
+
+XrdTpcNSSSupport::XrdTpcNSSSupport(XrdSysError *err, std::string ca_dir)
+    : m_log(*err),
+      m_ca_dir(ca_dir),
+      m_plugin(err, &g_ver, "Crypto Support", "libXrdCryptossl.so")
+{
+    if (!(m_x509_to_file_func = m_plugin.Resolve("XrdCryptosslX509ToFile")) ||

Actually, it appears we cannot link to this - that's why I had to go this direction (trust me, already tried! It's a pain to load like this and muck around with function pointers). CMake cowardly refuses to link to a shared module (as opposed to a shared library).

Another option would be to compile + link an extra copy of those functions just for HttpTpc; I don't particularly like that either.

I like the idea of doing a hard fail instead of falling back. Will work on that.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/xrootd/xrootd/pull/1431#discussion_r602004394", "url": "https://github.com/xrootd/xrootd/pull/1431#discussion_r602004394", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1