@abh3 commented on this pull request.
> @@ -485,9 +516,9 @@ int XrdCryptosslX509ParseFile(const char *fname,
rewind(fcer);
RSA *rsap = 0;
if (!PEM_read_RSAPrivateKey(fcer, &rsap, 0, 0)) {
- DEBUG("no RSA private key found in file "<<fname);
+ DEBUG("no RSA private key found in file");
Oh, didn't catch the deletion of fname as it was indirect. If the fname is constant and there is another message referring to it then there is no need. If it's always changing (e.g. the name of each crl or ca) then likely it's good to pass it in if only for debugging purposes.
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/xrootd/xrootd/pull/1431#discussion_r602012159
########################################################################
Use REPLY-ALL to reply to list
To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1
