@abh3 commented on this pull request.


In src/XrdTls/XrdTlsTempCA.cc:

> +        }
+    }
+    fflush(outputfp);
+
+    return true;
+}
+
+}
+
+
+std::unique_ptr<XrdTlsTempCA::TempCAGuard>
+XrdTlsTempCA::TempCAGuard::create(XrdSysError &err) {
+    char ca_fname[] = "/tmp/xrootd_ca_file.XXXXXX.pem";
+    int ca_fd = mkstemps(ca_fname, 4);
+    if (ca_fd < 0) {
+        err.Emsg("TempCA", "Failed to create temp file:", strerror(errno));

Referencing line 209; both messages are identical eventhough they actually refer to different files. To avoid confusion I suggest the message be:
"Failed to create CA temp file:"


You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/xrootd/xrootd/pull/1431#pullrequestreview-625904266", "url": "https://github.com/xrootd/xrootd/pull/1431#pullrequestreview-625904266", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1