@abh3 commented on this pull request. > + +} + + +std::unique_ptr<XrdTlsTempCA::TempCAGuard> +XrdTlsTempCA::TempCAGuard::create(XrdSysError &err) { + char ca_fname[] = "/tmp/xrootd_ca_file.XXXXXX.pem"; + int ca_fd = mkstemps(ca_fname, 4); + if (ca_fd < 0) { + err.Emsg("TempCA", "Failed to create temp file:", strerror(errno)); + return std::unique_ptr<TempCAGuard>(); + } + char crl_fname[] = "/tmp/xrootd_crl_file.XXXXXX.pem"; + int crl_fd = mkstemps(crl_fname, 4); + if (crl_fd < 0) { + err.Emsg("TempCA", "Failed to create temp file:", strerror(errno)); Referencing line 203; both messages are identical even though they actually refer to different files. To avoid confusion I suggest the message be: "Failed to create CRL temp file:" -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/xrootd/xrootd/pull/1431#pullrequestreview-625904587 ######################################################################## Use REPLY-ALL to reply to list To unsubscribe from the XROOTD-DEV list, click the following link: https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1