LISTSERV 16.5 - XROOTD-DEV Archives

@adriansev : sorry for the delay! The issue should be fix now with following commits: 04eb74a, 11f4ef7 and 3011213

There were actually two problems:

the client was not correctly handling the data descriptor record present at the end of file
this particular example is a corner case where the compressed size is slightly bigger then the uncompressed size:

zipinfo -v 66b0b4b0-c27c-11e8-82d6-626f12b4f71d
...
Central directory entry #4:
---------------------------

  There are an extra 16 bytes preceding this file.

  AliESDs.root

  offset of local header from start of archive:   75869382
                                                  (000000000485ACC6h) bytes
  file system or operating system of origin:      MS-DOS, OS/2 or NT FAT
  version of encoding software:                   2.0
  minimum file system compatibility required:     MS-DOS, OS/2 or NT FAT
  minimum software version required to extract:   2.0
  compression method:                             deflated
  compression sub-type (deflation):               normal
  file security status:                           not encrypted
  extended local header:                          yes
  file last modified on (DOS date/time):          2018 Sep 27 19:40:16
  32-bit CRC value (hex):                         c9faa31d
  compressed size:                                27764158 bytes
  uncompressed size:                              27759918 bytes
  length of filename:                             12 characters
  length of extra field:                          0 bytes
  length of file comment:                         0 characters
  disk number on which file begins:               disk 1
  apparent file type:                             binary
  non-MSDOS external file attributes:             000000 hex
  MS-DOS file attributes (00 hex):                none

  There is no file comment.
...

Note:
compressed size: 27764158 bytes
uncompressed size: 27759918 bytes

Now also this corner case should be handled correctly!

Could you give it a try before I close the ticket?

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/xrootd/xrootd/issues/1422#issuecomment-811793855", "url": "https://github.com/xrootd/xrootd/issues/1422#issuecomment-811793855", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1