The PR is cleaned up and includes the suggested changes

Skip the ERR_clear_error() additions in XrdHttp
Skip the "TLS error queue" reporting, as it's handled by XrdTls::Emsg()
Limit ERR_clear_error() calls to client connections
Add ERR_clear_error() to SSL_connect() for completeness

Just to add my 2 cents, we already had almost the same code in: d6434c8, but then we decided to revert it in favour of ccde53a. I suppose clearing the error queue ahead of SSL_read/SSL_write obsoletes ccde53a.

This is puzzling. I'd indeed think that the ClearErrorQueue() call at the end of DoAuthentication() should take care of it. Perhaps this is a thread-safety issue, I dunno.

When testing with gdb, one place triggering PEM_read_bio:no start line was XrdCryptosslX509ParseBucket, as the while loop parses until failure. Perhaps clearing the error queue there would make this commit unnecessary.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/xrootd/xrootd/pull/1464#issuecomment-852227098", "url": "https://github.com/xrootd/xrootd/pull/1464#issuecomment-852227098", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1