@abh3 commented on this pull request.
> @@ -44,12 +44,6 @@ int XrdOucCacheIO::pgRead(char *buff,
{
int bytes;
-// Make sure the offset is on a 4K boundary and the size is a multiple of
-// 4k as well (we use simple and for this).
-//
- if ((offs & XrdSys::PageMask)
- || (rdlen & XrdSys::PageMask)) return -EINVAL;
-
How this check is being removed? While I agree the test for requiring all reads to be a multiple of 4K is likely to strict, for the ache all reads must be page aligned. So, at least that check should have remained.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/xrootd/xrootd/pull/1510#pullrequestreview-748644793
########################################################################
Use REPLY-ALL to reply to list
To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1
