Hi Adrian,
Understood. I would prefer that we replace all occurrences of either
header file with <cstdint>. That provides the best compatibility and
adheres to what is expected in C++ programs. Otherwise, I totally agree
with you.
Andy
On Fri, 10 Sep 2021, Adrian Sevcenco wrote:
> @abh3 so, beside of the sl6 error that we have (and this PR is fixing it ), it is _not_ a good practice to use c headers in c++ code, and AFAIK there is always a recommendation to switch to usage of c++ includes (so `we always use either stdint.h or cstdint` is actually the problem that i'm talking about.).
> regarding this present issue, the problem is that c header did not correctly worked on gcc 7.3.0 and the problem is fixed with c++ header. given the wide usage of inttypes.h in xrootd code i gave the suggestion for the wide fix (not just in this file, just use cinttypes everywhere).
> Any other considerations, future developments, whole code refactoring and architecture decisions can be always done in future PRs i would say..
>
> --
> You are receiving this because you were mentioned.
> Reply to this email directly or view it on GitHub:
> https://github.com/xrootd/xrootd/pull/1511#issuecomment-916737178
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/xrootd/xrootd/pull/1511#issuecomment-916742165",
"url": "https://github.com/xrootd/xrootd/pull/1511#issuecomment-916742165",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]
Use REPLY-ALL to reply to list
To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1