Print

Print

I just tried on a fresh machine. Correct, it does not complain about json-c, likewise it is for UUID. The only thing it writes to error:

-- Checking for module 'json-c'
--   No package 'json-c' found
-- Checking for module 'uuid'
--   No package 'uuid' found

After those 2 devel packages are installed, the next issue seems it also need a libuuid-devel package (seems needed for Macaroons) Is there a reason? I would suggest making something like this:

diff --git a/cmake/XRootDFindLibs.cmake b/cmake/XRootDFindLibs.cmake
index 532c8ce..39654ad 100644
--- a/cmake/XRootDFindLibs.cmake
+++ b/cmake/XRootDFindLibs.cmake
@@ -95,10 +95,12 @@ endif()

 find_package( Macaroons )
 include (FindPkgConfig)
-pkg_check_modules(JSON json-c)
+pkg_check_modules(JSON json-c REQUIRED)
 pkg_check_modules(UUID uuid)
+pkg_check_modules(LIBUUID libuuid)

-if( MACAROONS_FOUND AND JSON_FOUND AND UUID_FOUND )
+
+if( MACAROONS_FOUND AND JSON_FOUND AND UUID_FOUND AND LIBUUID_FOUND )
   set( BUILD_MACAROONS TRUE )
 else()
   set( BUILD_MACAROONS FALSE )

It might not need anymore this JSON_FOUND... as it becomes REQUIRED

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.

[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/xrootd/xrootd/pull/1530#issuecomment-938950710", "url": "https://github.com/xrootd/xrootd/pull/1530#issuecomment-938950710", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1