@abh3 commented on this pull request. A couple of questions and perhaps needed changes before we merge this. Sorry for taking so long. > @@ -58,3 +58,5 @@ xrootd.spec dist *.egg-info bindings/python/VERSION +cmake-* +.idea/ Why are these being added? Is it a problem in your own repo? > @@ -198,11 +209,17 @@ CRLSet::processFile(file_smart_ptr &fp, const std::string &fname) return false; } } + if(!m_atLeastOneValidCRLFound) + m_atLeastOneValidCRLFound = atLeastOneValidCRLFound; Doesn't this mean that once a valid CRL is found a subsequent scan that doesn't find one will not be registered as such? Won't that be a problem? -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/xrootd/xrootd/pull/1547#pullrequestreview-819530851 ######################################################################## Use REPLY-ALL to reply to list To unsubscribe from the XROOTD-DEV list, click the following link: https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1