~~~ /builddir/build/BUILD/xrootd-5.3.2/src/XrdSys/XrdSysTrace.cc:177:22: error: comparison is always false due to limited range of data type [-Werror=type-limits] 177 | if (doHex < 0) doHex = 0; | ~~~~~~^~~ /builddir/build/BUILD/xrootd-5.3.2/src/XrdSys/XrdSysTrace.cc: In member function 'XrdSysTrace& XrdSysTrace::operator<<(short int)': /builddir/build/BUILD/xrootd-5.3.2/src/XrdSys/XrdSysTrace.cc:232:14: error: comparison is always false due to limited range of data type [-Werror=type-limits] 232 | if (doHex < 0) doHex = 0; | ~~~~~~^~~ /builddir/build/BUILD/xrootd-5.3.2/src/XrdSys/XrdSysTrace.cc: In member function 'XrdSysTrace& XrdSysTrace::operator<<(int)': /builddir/build/BUILD/xrootd-5.3.2/src/XrdSys/XrdSysTrace.cc:255:14: error: comparison is always false due to limited range of data type [-Werror=type-limits] 255 | if (doHex < 0) doHex = 0; | ~~~~~~^~~ /builddir/build/BUILD/xrootd-5.3.2/src/XrdSys/XrdSysTrace.cc: In member function 'XrdSysTrace& XrdSysTrace::operator<<(long long int)': /builddir/build/BUILD/xrootd-5.3.2/src/XrdSys/XrdSysTrace.cc:291:14: error: comparison is always false due to limited range of data type [-Werror=type-limits] 291 | if (doHex < 0) doHex = 0; | ~~~~~~^~~ /builddir/build/BUILD/xrootd-5.3.2/src/XrdSys/XrdSysTrace.cc: In member function 'XrdSysTrace& XrdSysTrace::operator<<(short unsigned int)': /builddir/build/BUILD/xrootd-5.3.2/src/XrdSys/XrdSysTrace.cc:314:14: error: comparison is always false due to limited range of data type [-Werror=type-limits] 314 | if (doHex < 0) doHex = 0; | ~~~~~~^~~ /builddir/build/BUILD/xrootd-5.3.2/src/XrdSys/XrdSysTrace.cc: In member function 'XrdSysTrace& XrdSysTrace::operator<<(unsigned int)': /builddir/build/BUILD/xrootd-5.3.2/src/XrdSys/XrdSysTrace.cc:337:14: error: comparison is always false due to limited range of data type [-Werror=type-limits] 337 | if (doHex < 0) doHex = 0; | ~~~~~~^~~ /builddir/build/BUILD/xrootd-5.3.2/src/XrdSys/XrdSysTrace.cc: In member function 'XrdSysTrace& XrdSysTrace::operator<<(long long unsigned int)': /builddir/build/BUILD/xrootd-5.3.2/src/XrdSys/XrdSysTrace.cc:373:14: error: comparison is always false due to limited range of data type [-Werror=type-limits] 373 | if (doHex < 0) doHex = 0; | ~~~~~~^~~ ~~~ This PR is against stable-5.3.x since the code has changed in master. You can view, comment on, or merge this pull request online at: https://github.com/xrootd/xrootd/pull/1546 -- Commit Summary -- * <a href="https://github.com/xrootd/xrootd/pull/1546/commits/6ab8bc65e20d2c4e8a1471bb168d9a9dffd03c33">Fix build failure on platforms where char is unsigned (ARM, PPC and S390X)</a> -- File Changes -- M src/XrdSys/XrdSysTrace.hh (2) -- Patch Links -- https://github.com/xrootd/xrootd/pull/1546.patch https://github.com/xrootd/xrootd/pull/1546.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/xrootd/xrootd/pull/1546 ######################################################################## Use REPLY-ALL to reply to list To unsubscribe from the XROOTD-DEV list, click the following link: https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1