@simonmichal : The compiler is your old favourite gcc 4.8 on RHEL/CentOS 7.

I have looked into this a bit more, and there is a really sneaky issue here.
Even though the regex_replace with the signature with std::string exists in the version of libstdc++ that accompanies the compiler, and the code compiles with the proposed change, it doesn't work.
Looking into the headers, there is a comment that says:

   * @todo Implement this function.

One would have hoped that this would rather fail to compile, or at least result in a compilation warning. But no - it successfully compiles and you have to read the comments in the headers to know it is not working.
So this PR will not fix it. So I suggest not merging it.

I do have a question though. What is the intention of this replacement? I see that it wants to replace 2 consecutive slashes with one, but what is supposed to happen with 3 or more consecutive slashes? Currently 3 or 4 consecutive slashes become 2. 5 or 6 consecutive slashes become 3. And so on. Was this intended? It seems odd. Or was the intention to replace any number of consecutive slashes with a single one. In that case the regex should be "/+", not "//".

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.

Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1