Looking at the code for MakeCanonical() we are far better off using
regex(). So, I very much would prefer *not* to use MakeCanonical() it's
dreadfully ineffecient.
On Tue, 14 Dec 2021, Elvin Sindrilaru wrote:
> @ellert you are right, a better regex would be "/+" to be replaced with "/". In this particular case, the individual paths are already in canonical format, so it was just the concatenation which could create paths with double slashes. I can drop the use of std::regex and can use the already provided `MakeCanonical` function from the XrdSciTokensAccess.cc file. Let me know what you prefer.
>
> --
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly or view it on GitHub:
> https://github.com/xrootd/xrootd/pull/1571#issuecomment-993397738
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/xrootd/xrootd/pull/1571#issuecomment-993940417",
"url": "https://github.com/xrootd/xrootd/pull/1571#issuecomment-993940417",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]
Use REPLY-ALL to reply to list
To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1
