 |
 |
You know, it strikes me that double-nested for loop is generating strings that depend solely on the configuration -- i.e., you could hoist the code to the configuration functions and generate them once instead of on every authorization.
In terms of MakeCanonical: if we don't like the current implementation of MakeCanonical, let's make a better implementation. This is a place where we need a canonical path and, instead of using the helper function to do exactly that, we wrote a single line that fails to make the path canonical in various cases (notice the merged fix handles // correctly but not ///; does not handle .. or .).
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
Use REPLY-ALL to reply to list
To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1