Print

Print

@bbockelm commented on this pull request.

In src/XrdOuc/XrdOucString.cc:

> @@ -257,7 +257,7 @@ int XrdOucString::form(XrdOucString &str, const char *fmt, ...)
 #endif
 
 //______________________________________________________________________________
-int XrdOucString::find(const char c, int start, bool forward)
+int XrdOucString::find(const char c, int start, bool forward) const

Rats. I thought const'ness of the symbol wasn't part of the GCC C++ ABI... turns out it's not part of the GCC C ABI.

No problem, will revert and do ugly const_cast workarounds at the call sites.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.Message ID: <xrootd/xrootd/pull/1572/review/844592741@github.com>

[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/xrootd/xrootd/pull/1572#discussion_r778813863", "url": "https://github.com/xrootd/xrootd/pull/1572#discussion_r778813863", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1