Print

Print


@bbockelm commented on this pull request.


In src/XrdVoms/XrdVomsMapfile.cc:

> +XrdVomsMapfile::Reconfigure() {
+    auto now = time(NULL);
+    auto retval = true;
+    std::stringstream ss;
+    ss << "Last update " << m_last_update.load(std::memory_order_relaxed) << ", " << now;
+    m_edest->Log(LogMask::Debug, "VOMS Mapfile", ss.str().c_str());
+    if (now > m_last_update.load(std::memory_order_relaxed) + 30) {
+        retval = ParseMapfile(m_mapfile);
+        m_last_update.store(now, std::memory_order_relaxed);
+    }
+    return retval;
+}
+
+
+bool
+XrdVomsMapfile::ParseLine(const std::string &line, std::vector<std::string> &entry, std::string &target)

Sure. How about I also add it to a module-specific README? The parsing rules are taken from here:

https://argus-documentation.readthedocs.io/en/stable/misc/grid_map_file.html

(except I will decline to support generic 8-bit ASCII or generic unicode escape sequences as those are not permitted in IGTF... would rather someone really convince me unicode support in DNs is a good idea!)

I wasn't able to find a document for the wildcard / matching rules so I took them from the existing implementation in order to allow sites to reuse their existing voms-mapfiles. Would be good to have them written down.


Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.Message ID: <xrootd/xrootd/pull/1572/review/844604717@github.com>

[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/xrootd/xrootd/pull/1572#discussion_r778822039", "url": "https://github.com/xrootd/xrootd/pull/1572#discussion_r778822039", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1