@abh3 commented on this pull request.


In src/XrdVoms/XrdVomsMapfile.cc:

> +int
+XrdVomsMapfile::GetSecData(XrdLink * lnk, XrdSecEntity &entity, SSL *ssl)
+{
+    if (!m_xrdvoms) return -1;
+
+    auto retval = m_xrdvoms->GetSecData(lnk, entity, ssl);
+    if (retval) return retval;
+
+    return Apply(entity);
+}
+
+
+int
+XrdVomsMapfile::Apply(XrdSecEntity &entity)
+{
+    Reconfigure();

The alternative solution is to extend the time to something reasonable but keep track of the mtime and reparse only if the mtime changed within that interval. This also works but at the cost but random slowness in doing the mapping when you have to reparse. The thread solution avoids this problem.


Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.Message ID: <xrootd/xrootd/pull/1572/review/847089763@github.com>

[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/xrootd/xrootd/pull/1572#discussion_r780601733", "url": "https://github.com/xrootd/xrootd/pull/1572#discussion_r780601733", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1