@abh3 commented on this pull request.


In src/XrdVoms/XrdVomsMapfile.cc:

> +XrdVomsMapfile::Reconfigure() {
+    auto now = time(NULL);
+    auto retval = true;
+    std::stringstream ss;
+    ss << "Last update " << m_last_update.load(std::memory_order_relaxed) << ", " << now;
+    m_edest->Log(LogMask::Debug, "VOMS Mapfile", ss.str().c_str());
+    if (now > m_last_update.load(std::memory_order_relaxed) + 30) {
+        retval = ParseMapfile(m_mapfile);
+        m_last_update.store(now, std::memory_order_relaxed);
+    }
+    return retval;
+}
+
+
+bool
+XrdVomsMapfile::ParseLine(const std::string &line, std::vector<std::string> &entry, std::string &target)

A READ_ME file is OK and I suppose I will have to convert it to reference text as people defining the map file generally do not install the source. Pointing then to the argus page won't help either because, well as you said, you don't support all of it and completely agree with you we don't need to support all of it.


Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.Message ID: <xrootd/xrootd/pull/1572/review/847092508@github.com>

[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/xrootd/xrootd/pull/1572#discussion_r780604237", "url": "https://github.com/xrootd/xrootd/pull/1572#discussion_r780604237", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1