> could you please remove lines 84 and 105 from python/CMakeLists.txt hence don't update the packages from within cmake we don't do that by policy (similarly as we don't do yum install, apt-get install and so on)
@simonmichal I think these comments are with regards to the changes in PR #1586. I want to try to step through these as separate PRs as they're distinct but complimentary changes, though your comment
> could you please update the spec file so there is a respective BuildRequires for `python-setuptools`, currently the PR breaks our RPM builds
is relevant on this one. Though related to breaking the RPM builds, can you please tell me how to run the test suite, as in my Dockerfile above `ENABLE_TESTS=ON` isn't sufficient
```dockerfile
cmake \
-DCMAKE_INSTALL_PREFIX=/usr/local/venv \
-DPYTHON_EXECUTABLE=$(command -v python3) \
-DENABLE_TESTS=ON \
-S xrootd \
-B build && \
```
Also, related to Issue #1588, how is the CI being run and how can contributors run it before requesting review?
> * if I build and install the wheel on CC7 container:
>
> ```
> yum install --nogpg -y git python3-pip which
> python3 -m pip install --upgrade pip
> python3 -m pip install setuptools wheel --upgrade
> cp packaging/wheel/* .
> ./publish.sh
> python3 -m pip install ./dist/xrootd-*.tar.gz
> ```
> and then try using xrootd client from within python I get following error:
>
> ```
> >>> from XRootD import client
> Traceback (most recent call last):
> File "<stdin>", line 1, in <module>
> File "/usr/local/lib64/python3.6/site-packages/XRootD/client/__init__.py", line 3, in <module>
> from .glob_funcs import glob, iglob
> File "/usr/local/lib64/python3.6/site-packages/XRootD/client/glob_funcs.py", line 26, in <module>
> from XRootD.client.filesystem import FileSystem
> File "/usr/local/lib64/python3.6/site-packages/XRootD/client/filesystem.py", line 26, in <module>
> from pyxrootd import client
> ImportError: libXrdCl.so.3: cannot open shared object file: No such file or directory
> ```
Is this happening for both PRs or just PR #1586?
Here `LD_LIBRARY_PATH` isn't being set properly. If you have the equivalent of
```
export LD_LIBRARY_PATH=/usr/local/lib:"${LD_LIBRARY_PATH}"
```
occur then this would be resolved.
Note, no wheel is ever made here. You only have an sdist with `xrootd-*.tar.gz`.
--
Reply to this email directly or view it on GitHub:
https://github.com/xrootd/xrootd/pull/1585#issuecomment-1011142603
You are receiving this because you are subscribed to this thread.
Message ID: <[log in to unmask]>
########################################################################
Use REPLY-ALL to reply to list
To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1
