@matthewfeickert commented on this pull request.

> +concurrency:
+  group: build-${{ github.ref }}
+  cancel-in-progress: true

This concurrency group will automatically cancel previous runs if a run on the same branch is triggered.

In .github/workflows/build.yml:

> +    - master
+  schedule:
+    - cron:  '23 1 * * 0'
+  release:
+    types: [published]
+  workflow_dispatch:
+
+defaults:
+  run:
+    shell: bash
+
+concurrency:
+  group: build-${{ github.ref }}
+  cancel-in-progress: true
+
+jobs:

GitHub Actions is a bit verbose, so there isn't much of a way to simplify this at the moment.

In .github/workflows/build.yml:

> +    # Need to use v1 of action as image Git is too old
+    - name: Clone repository now that Git is available
+      uses: actions/checkout@v1

The faster/nicer v2 of this action requires Git 2.18, and CentOS 7 ships v1.8.3.1, so fall back to the old version here which still works.

In .github/workflows/build.yml:

> +        # ./common/test-runner ./XrdClTests/libXrdClTests.so 'All Tests/PostMasterTest/'
+        # ./common/test-runner ./XrdClTests/libXrdClTests.so 'All Tests/FileSystemTest/'
+        # ./common/test-runner ./XrdClTests/libXrdClTests.so 'All Tests/LocalFileHandlerTest/'

These tests failed, so I left them in here as a TODO of sorts.

In .github/workflows/build.yml:

> +            cmake3 \
+            make \
+            krb5-devel \
+            libuuid-devel \
+            libxml2-devel \
+            openssl-devel \
+            systemd-devel \
+            zlib-devel \
+            devtoolset-7-gcc-c++ \
+            which \
+            python3-devel \
+            python3-setuptools \
+            git \
+            cppunit-devel
+        yum clean all
+        python3 -m pip --no-cache-dir install --upgrade pip setuptools wheel

I've added these updated-python jobs as it is important to check for changes that have happened in the pip and setuptools world that happen since CentOS 7 ships very old releases. Future Debian jobs will do a better job of checking this, as they have newer CPython releases while CentOS's Python 3.6 is capped out at setuptools 59.6.0 as setuptools 59.7.0+ is Python 3.7+.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.

[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/xrootd/xrootd/pull/1591#pullrequestreview-853154262", "url": "https://github.com/xrootd/xrootd/pull/1591#pullrequestreview-853154262", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1