Print

Print

@simonmichal commented on this pull request.

In src/XrdCl/XrdClXCpSrc.cc:

> @@ -94,7 +94,7 @@ class ChunkHandler: public ResponseHandler
       {
         ChunkInfo *rsp = nullptr;
         response->Get( rsp );
-        *chunk = PageInfo( rsp->offset, rsp->length, rsp->buffer );
+        chunk = new PageInfo( rsp->offset, rsp->length, rsp->buffer );
         response->Set( ( int* )0 );

You are absolutely correct that the PageInfo object needs to be allocated. Just to make the patch complete, could you also remove the line 98 as the response (AnyObject) needs to maintain the ownership of the ChunkInfo?

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.Message ID: <xrootd/xrootd/pull/1592/review/855097689@github.com>

[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/xrootd/xrootd/pull/1592#pullrequestreview-855097689", "url": "https://github.com/xrootd/xrootd/pull/1592#pullrequestreview-855097689", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1