@matthewfeickert commented on this pull request.

@simonmichal your comment with the error should now be addressed.

> +# Determine if wheel.bdist_wheel is available for wheel.bdist_wheel in setup.py
+python3 -c 'import wheel' &> /dev/null
+wheel_available=$?
+if [ "${wheel_available}" -ne "0" ]; then
+    python3 -m pip install wheel
+    wheel_available=$?
+
+    if [ "${wheel_available}" -ne "0" ]; then
+        echo "ERROR: Unable to find wheel and unable to install wheel with '$(command -v python3) -m pip install wheel'."
+        echo "       Please ensure wheel is available to $(command -v python3) and try again."
+        exit 1
+    fi
+fi
+unset wheel_available
+
+# Determine if build is available
+python3 -c 'import build' &> /dev/null
+build_available=$?
+if [ "${build_available}" -ne "0" ]; then
+    python3 -m pip install build
+    build_available=$?
+fi
+
+if [ "${build_available}" -ne "0" ]; then
+    echo "WARNING: Unable to find build and unable to install build from PyPI with '$(command -v python3) -m pip install build'."
+    echo "         Falling back to building sdist with '$(command -v python3) setup.py sdist'."
+    python3 setup.py sdist
+else
+    python3 -m build --sdist .
+fi
+unset build_available

I cleaned up the logic here so that the errors @simonmichal was seeing should be eliminated now.

In .github/workflows/build.yml:

> +    - name: Build sdist using publishing workflow
+      run: |
+        . /opt/rh/devtoolset-7/enable
+        cp packaging/wheel/* .
+        ./publish.sh
+        ls -lhtra dist/

@simonmichal I added in this chunk into the CI after the RPM build so that your comment is now tested against in the case of the RPM install.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.

[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/xrootd/xrootd/pull/1585#pullrequestreview-855714598", "url": "https://github.com/xrootd/xrootd/pull/1585#pullrequestreview-855714598", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1