This is pretty minor as it only affects release candidates and doesn't actually cause any problems as setuptools
is smart enough to catch and fix it, but in PR #1605 I didn't properly account for release candidate versions like v5.4.1-rc2
. Note both v5.4.1-rc2
and v5.4.1.rc2
will get sanitized to v5.4.1rc2
by pip
and setuptools
>>> from pip._vendor.packaging.version import Version
>>> Version("v5.4.1-rc2")
<Version('5.4.1rc2')>
>>> Version("v5.4.1.rc2")
<Version('5.4.1rc2')>
>>> Version("v5.4.1rc2")
<Version('5.4.1rc2')>
As
was expecting something of the form "v5.4.1rc2"
, it doesn't properly catch v5.4.1-rc2
and instead transforms it into 5.4.1.rc2
. As mentioned, pip
and setuptools
can still work with this, but in the build will give something like
XRootD library dir: /code/build/src
XRootD src include dir: /code/xrootd/src
XRootD bin include dir: /code/build/src
Version: 5.4.1.rc2
/usr/local/venv/lib/python3.9/site-packages/setuptools/dist.py:505: UserWarning: Normalizing '5.4.1.rc2' to '5.4.1rc2'
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.
Use REPLY-ALL to reply to list
To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1