There are three commits, each to a distinct file. All involve using vector::resize instead of reserve, and vector::size instead of capacity, and the unmodified code produces a bounds-checking assertion failure in vector::operator[] when compiled with -D_GLIBCXX_ASSERTIONS. A smoke test was applied to the first two commits to verify that they eliminate a problem.
The first (in XrdMacaroonsHandler.cc) specifically fixes #1614. Although already closed, I think this change would be more readable.
The second (in XrdTpcStream.hh) is in code that was not engaged/discovered during the smoke test until the first was fixed.
The third (in XrdThrottleManager.cc) was found just by a scan of the code, and is not engaged by our configuration. However, adding xrootd.fslib throttle default does engage it, and causes the assertion failure as soon as the process starts up without the fix.

You can view, comment on, or merge this pull request online at:

  https://github.com/xrootd/xrootd/pull/1630

Commit Summary

• 989e088 Set vector's logical size to avoid bounds-checking failure.
• 666d8ac Vector must be resized to prevent bounds-checking assertion failure.
• bac553b Vectors resized to prevent bounds-checking assertion failures.

File Changes

(3 files)

• M src/XrdMacaroons/XrdMacaroonsHandler.cc (2)
• M src/XrdThrottle/XrdThrottleManager.cc (8)
• M src/XrdTpc/XrdTpcStream.hh (4)

Patch Links:

• https://github.com/xrootd/xrootd/pull/1630.patch
• https://github.com/xrootd/xrootd/pull/1630.diff

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.Message ID: <xrootd/xrootd/pull/1630@github.com>

Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1